Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] support disable shutdown hook #8369

Merged
merged 1 commit into from Jul 29, 2021

Conversation

@kylixs
Copy link
Contributor

@kylixs kylixs commented Jul 29, 2021

What is the purpose of the change

support disable shutdown hook for special scenario.

config key: dubbo.lifecycle.disable-shutdown-hook

Disable dubbo shutdown hook, Default value is false.
When disable the shutdown hook, you may need to do :

  1. offline all services by qos manually before shutdown dubbo application
  2. no DubboBootstrapStopedEvent will be sent
  3. all ShutdownHookCallback will not be called
  4. dubbo application will not be destroyed when spring context is closed

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@AlbumenJ AlbumenJ merged commit b48b792 into apache:3.0 Jul 29, 2021
2 checks passed
@kylixs kylixs deleted the 3.0-support-disable-shutdown-hook branch Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants