New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #8378 parameter convert error #8379
Conversation
4d689fc
to
5caae55
Compare
Codecov Report
@@ Coverage Diff @@
## master #8379 +/- ##
============================================
- Coverage 61.20% 61.07% -0.13%
- Complexity 446 448 +2
============================================
Files 1096 1097 +1
Lines 44223 44401 +178
Branches 6445 6469 +24
============================================
+ Hits 27066 27119 +53
- Misses 14176 14296 +120
- Partials 2981 2986 +5
Continue to review full report at Codecov.
|
@24kpure please add some unit tests for parameters converting method and list all supported formats in java doc. |
Thanks for your advice.I have added a unit test for paramters converting method and listed supported formats in java doc.It‘s my first time to add unit test in Dubbo.Why not give more advice to me? |
@kylixs Is there something wrong with the pr? |
What is the purpose of the change
#8378
Brief changelog
Sevice and reference convert parameter in the same method,which is compatible with symbol(:) colon and and equal(=).As As for other config, like mock ,it works as well.
Verifying this change
Checklist