Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Add Dynamic Configuration Override Support For ServiceDiscovery #8389

Merged
merged 1 commit into from Aug 3, 2021

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Aug 2, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #8389 (70e5b1d) into master (ca794b6) will decrease coverage by 0.17%.
The diff coverage is 11.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8389      +/-   ##
============================================
- Coverage     61.20%   61.02%   -0.18%     
- Complexity      446      448       +2     
============================================
  Files          1096     1097       +1     
  Lines         44223    44393     +170     
  Branches       6445     6469      +24     
============================================
+ Hits          27066    27092      +26     
- Misses        14176    14314     +138     
- Partials       2981     2987       +6     
Impacted Files Coverage Δ
...bo/registry/client/OverrideInstanceAddressURL.java 0.00% <0.00%> (ø)
...e/dubbo/registry/integration/RegistryProtocol.java 60.30% <0.00%> (-0.19%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 13.52% <22.72%> (+6.80%) ⬆️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 74.35% <0.00%> (-5.13%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...o/rpc/cluster/support/migration/MigrationRule.java 42.10% <0.00%> (-2.64%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca794b6...70e5b1d. Read the comment docs.

@zonghaishang zonghaishang merged commit fc2808b into apache:master Aug 3, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants