Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on branch master, consumer invoke timeout cause NPE. #8587

Merged
merged 2 commits into from Aug 25, 2021

Conversation

wangchengming666
Copy link
Contributor

@wangchengming666 wangchengming666 commented Aug 24, 2021

issue no #8586

Copy link
Contributor

@changfubai changfubai left a comment

LGTM.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

LGTM

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #8587 (b523377) into master (fd80172) will decrease coverage by 0.75%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8587      +/-   ##
============================================
- Coverage     61.04%   60.28%   -0.76%     
+ Complexity      448      446       -2     
============================================
  Files          1097     1097              
  Lines         44407    44361      -46     
  Branches       6470     6439      -31     
============================================
- Hits          27109    26744     -365     
- Misses        14313    14637     +324     
+ Partials       2985     2980       -5     
Impacted Files Coverage Δ
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 50.00% <0.00%> (-0.67%) ⬇️
...he/dubbo/rpc/protocol/dubbo/DubboCodecSupport.java 64.28% <77.77%> (ø)
...gcenter/wrapper/CompositeDynamicConfiguration.java 0.00% <0.00%> (-73.34%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-66.67%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-62.86%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 31.42% <0.00%> (-54.29%) ⬇️
.../dubbo/metadata/report/MetadataReportInstance.java 12.50% <0.00%> (-40.63%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-34.29%) ⬇️
...gistry/client/migration/MigrationRuleListener.java 55.88% <0.00%> (-23.53%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-20.69%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd80172...b523377. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 4c8a54e into apache:master Aug 25, 2021
10 checks passed
@wangchengming666 wangchengming666 deleted the fix-master-#8586 branch Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants