Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix ignored interface name matches method #8629

Merged
merged 6 commits into from Sep 8, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Aug 28, 2021

What is the purpose of the change

fix #8581

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #8629 (ab783e2) into master (fd80172) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8629      +/-   ##
============================================
+ Coverage     61.04%   61.07%   +0.03%     
- Complexity      448      449       +1     
============================================
  Files          1097     1097              
  Lines         44407    44415       +8     
  Branches       6470     6472       +2     
============================================
+ Hits          27109    27128      +19     
+ Misses        14313    14301      -12     
- Partials       2985     2986       +1     
Impacted Files Coverage Δ
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 50.00% <0.00%> (-0.67%) ⬇️
...he/dubbo/rpc/protocol/dubbo/DubboCodecSupport.java 64.28% <77.77%> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.35% <100.00%> (+0.04%) ⬆️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.10% <0.00%> (+0.21%) ⬆️
...he/dubbo/registry/multicast/MulticastRegistry.java 68.37% <0.00%> (+0.93%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0.00%> (+2.97%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8a54e...ab783e2. Read the comment docs.

@zrlw zrlw changed the title set literal pattern string for ignored given interface name tests fix #8581 Aug 28, 2021
Copy link
Contributor

@wangchengming666 wangchengming666 left a comment

LGTM.

@zrlw
Copy link
Contributor Author

@zrlw zrlw commented Aug 29, 2021

@wangchengming666 pls review again

@zrlw zrlw changed the title fix #8581 [master] fix ignored interface name matches method Sep 5, 2021
@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Sep 8, 2021

Please check if it is necessary to patch to 3.0 branch.

@AlbumenJ AlbumenJ merged commit 485aac1 into apache:master Sep 8, 2021
10 checks passed
@zrlw
Copy link
Contributor Author

@zrlw zrlw commented Sep 8, 2021

Please check if it is necessary to patch to 3.0 branch.

#8723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants