Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix destroy IllegalStateException and doOverrideIfNecessary NPE #8683

Merged
merged 1 commit into from Sep 12, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 5, 2021

What is the purpose of the change

fix #8681 on master

@zrlw zrlw changed the title fix destroy NullPointerException and doOverrideIfNecessary [master] fix destroy NullPointerException and doOverrideIfNecessary Sep 5, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #8683 (e09ea60) into master (7d95364) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8683      +/-   ##
============================================
+ Coverage     61.03%   61.07%   +0.03%     
+ Complexity      448      447       -1     
============================================
  Files          1097     1097              
  Lines         44398    44406       +8     
  Branches       6466     6469       +3     
============================================
+ Hits          27098    27119      +21     
+ Misses        14317    14301      -16     
- Partials       2983     2986       +3     
Impacted Files Coverage Δ
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 75.00% <75.00%> (ø)
...e/dubbo/registry/integration/RegistryProtocol.java 62.31% <83.33%> (+2.00%) ⬆️
...ava/org/apache/dubbo/config/DubboShutdownHook.java 84.61% <0.00%> (-3.85%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.89% <0.00%> (-0.43%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 68.37% <0.00%> (+0.93%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 80.37% <0.00%> (+2.22%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d95364...e09ea60. Read the comment docs.

@zrlw zrlw changed the title [master] fix destroy NullPointerException and doOverrideIfNecessary [master] fix destroy NPE and doOverrideIfNecessary IllegalStateException Sep 6, 2021
@zrlw zrlw changed the title [master] fix destroy NPE and doOverrideIfNecessary IllegalStateException [master] fix destroy IllegalStateExceptionand doOverrideIfNecessary NPE Sep 10, 2021
@zrlw zrlw changed the title [master] fix destroy IllegalStateExceptionand doOverrideIfNecessary NPE [master] fix destroy IllegalStateException and doOverrideIfNecessary NPE Sep 10, 2021
@AlbumenJ AlbumenJ merged commit e63a7be into apache:master Sep 12, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants