Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] close client immediately when destroy unused invoker #8756

Merged
merged 1 commit into from Sep 12, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 9, 2021

What is the purpose of the change

fix #8752 #8748 #6404 on master

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #8756 (a21557f) into master (abb2109) will decrease coverage by 0.70%.
The diff coverage is 45.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8756      +/-   ##
============================================
- Coverage     61.04%   60.33%   -0.71%     
+ Complexity      448      446       -2     
============================================
  Files          1097     1099       +2     
  Lines         44383    44350      -33     
  Branches       6460     6429      -31     
============================================
- Hits          27093    26759     -334     
- Misses        14309    14622     +313     
+ Partials       2981     2969      -12     
Impacted Files Coverage Δ
...stry/client/ServiceDiscoveryRegistryDirectory.java 13.52% <0.00%> (ø)
...apache/dubbo/remoting/exchange/ExchangeClient.java 0.00% <0.00%> (ø)
...c/protocol/dubbo/ReferenceCountExchangeClient.java 63.33% <40.00%> (-2.74%) ⬇️
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 70.42% <42.85%> (-3.43%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 76.17% <100.00%> (ø)
...pi/src/main/java/org/apache/dubbo/rpc/Invoker.java 100.00% <100.00%> (ø)
...gcenter/wrapper/CompositeDynamicConfiguration.java 0.00% <0.00%> (-73.34%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-66.67%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-62.86%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 31.42% <0.00%> (-54.29%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb2109...a21557f. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 55dec92 into apache:master Sep 12, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants