Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readability of the getOrder method #9361

Merged
merged 1 commit into from Dec 16, 2021

Conversation

tianshuang
Copy link
Contributor

@tianshuang tianshuang commented Dec 6, 2021

Ordered.LOWEST_PRECEDENCE + 1 is equal to Ordered.HIGHEST_PRECEDENCE, using Ordered.HIGHEST_PRECEDENCE is more readable.

What is the purpose of the change

Improve the readability of the getOrder method.

Brief changelog

Improve the readability of the getOrder method.

Verifying this change

Same semantics, avoiding integer overflow.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

`Ordered.LOWEST_PRECEDENCE + 1` is equal to `Ordered.HIGHEST_PRECEDENCE`, using `Ordered.HIGHEST_PRECEDENCE` is more readable.
Copy link
Contributor

@BurningCN BurningCN left a comment

LGTM

@chickenlj chickenlj added this to the 2.7.15 milestone Dec 16, 2021
@chickenlj chickenlj merged commit 578bfcb into apache:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants