Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade log4j2 version to 2.17.0 #9444

Merged
merged 1 commit into from Dec 20, 2021

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Dec 18, 2021

What is the purpose of the change

https://logging.apache.org/log4j/2.x/security.html#CVE-2021-45105

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #9444 (f11a81c) into master (63e714a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9444      +/-   ##
============================================
+ Coverage     60.84%   60.86%   +0.02%     
+ Complexity      447      446       -1     
============================================
  Files          1100     1100              
  Lines         44515    44515              
  Branches       6477     6477              
============================================
+ Hits          27085    27095      +10     
+ Misses        14461    14450      -11     
- Partials       2969     2970       +1     
Impacted Files Coverage Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../dubbo/monitor/support/AbstractMonitorFactory.java 80.00% <0.00%> (-3.34%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.79% <0.00%> (-1.13%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.10% <0.00%> (-0.22%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+1.48%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (+2.81%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e714a...f11a81c. Read the comment docs.

@CrazyHZM CrazyHZM merged commit 8cc9579 into apache:master Dec 20, 2021
10 checks passed
@CrazyHZM CrazyHZM deleted the 2.7.x_fix/upgrade_log4j2_version branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants