Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local references support mergeable #9645

Merged

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Solve #8777

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM changed the title Local refer support mergeable Local references support mergeable Jan 31, 2022
@CrazyHZM CrazyHZM added this to the 3.0.6 milestone Jan 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #9645 (0e41bcd) into 3.0 (dfe4fca) will increase coverage by 0.10%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9645      +/-   ##
============================================
+ Coverage     65.59%   65.70%   +0.10%     
+ Complexity      297      296       -1     
============================================
  Files          1191     1191              
  Lines         52068    52123      +55     
  Branches       7907     7920      +13     
============================================
+ Hits          34154    34246      +92     
+ Misses        14231    14182      -49     
- Partials       3683     3695      +12     
Impacted Files Coverage Δ
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 83.63% <88.00%> (+2.38%) ⬆️
.../java/org/apache/dubbo/config/ReferenceConfig.java 81.96% <100.00%> (-0.22%) ⬇️
...ache/dubbo/registry/multiple/MultipleRegistry.java 60.75% <100.00%> (ø)
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 74.73% <100.00%> (+2.57%) ⬆️
...che/dubbo/qos/probe/impl/DeployerStartupProbe.java 84.61% <0.00%> (-15.39%) ⬇️
...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java 84.61% <0.00%> (-15.39%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java 87.50% <0.00%> (-6.25%) ⬇️
...spring/context/DubboConfigApplicationListener.java 73.33% <0.00%> (-5.24%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe4fca...0e41bcd. Read the comment docs.

@chickenlj chickenlj modified the milestones: 3.0.6, 3.0.7 Mar 3, 2022
@chickenlj chickenlj requested a review from AlbumenJ March 15, 2022 13:33
@chickenlj chickenlj modified the milestones: 3.0.7, 3.0.8 Mar 28, 2022
@chickenlj chickenlj modified the milestones: 3.0.8, 3.0.9 May 12, 2022
@AlbumenJ AlbumenJ modified the milestones: 3.0.9, 3.0.10 Jun 20, 2022
@AlbumenJ AlbumenJ modified the milestones: 3.0.10, 3.1.0 Jul 16, 2022
@AlbumenJ AlbumenJ modified the milestones: 3.1.0, 3.1.1 Aug 16, 2022
@chickenlj chickenlj merged commit 72326f4 into apache:3.0 Sep 8, 2022
@chickenlj chickenlj modified the milestones: 3.1.1, 3.0.12 Sep 8, 2022
@CrazyHZM CrazyHZM deleted the feature/local_refer_support_mergeable branch September 8, 2022 06:12
@AlbumenJ AlbumenJ mentioned this pull request Oct 8, 2022
1 task
AlbumenJ added a commit that referenced this pull request Oct 8, 2022
@AlbumenJ
Copy link
Member

AlbumenJ commented Oct 8, 2022

这个PR会导致 ClusterFilter 在 Filter 之后工作。

Filter 的织入是在 org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper,而 PR 修改完 ClusterFilter 是在 org.apache.dubbo.rpc.protocol.injvm.InjvmProtocol#doCreateInvoker 才织入

AlbumenJ added a commit that referenced this pull request Oct 9, 2022
AlbumenJ added a commit that referenced this pull request Nov 21, 2022
AlbumenJ added a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants