Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

EAGLE-79 Provide basic aggregation #52

Closed
wants to merge 38 commits into from
Closed

EAGLE-79 Provide basic aggregation #52

wants to merge 38 commits into from

Conversation

RalphSu
Copy link
Contributor

@RalphSu RalphSu commented Jan 4, 2016

https://issues.apache.org/jira/browse/EAGLE-79

  1. Support aggregation api
  2. Support persist Api
  3. Refactor AlertExecutor to be policy wide.

* @since Dec 21, 2015
*
*/
public class DruidPersistService implements IPersistService<AggregateEntity> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you think to rename the DruidPersistService to KafkaPersistService here as it's for kafka only in fact? We may have another DruidPersistService using https://github.com/druid-io/tranquility later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion, kafakpersistservice seems better.

@haoch
Copy link
Member

haoch commented Jan 5, 2016

Have you implemented the inline sql-based-policy interface?

@RalphSu
Copy link
Contributor Author

RalphSu commented Jan 5, 2016

For sql-based-policy, i think it mean an policy executor accept a fixed sql. This would be added later, not in this commit.

@haoch
Copy link
Member

haoch commented Jan 5, 2016

Ok, i think the pull request is good for me.

@sunlibin
Copy link
Contributor

The PR looks good to me

@RalphSu
Copy link
Contributor Author

RalphSu commented Jan 11, 2016

Add aggregate purely on single user given QL support

@haoch
Copy link
Member

haoch commented Jan 12, 2016

LGTM 👍

@haoch
Copy link
Member

haoch commented Jan 12, 2016

Will merge this pull request into master branch today if no additional comments.

@asfgit asfgit closed this in da8f419 Jan 12, 2016
@haoch
Copy link
Member

haoch commented Jan 12, 2016

@RalphSu thanks for the contribution and pull request has been merged, please resolve the JIRA ticket https://issues.apache.org/jira/browse/EAGLE-79.

@haoch
Copy link
Member

haoch commented Jan 12, 2016

Got RAT exception, but it doesn't matter, i will fix it.

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (header-check) on project eagle-policy-base: Too many files with unapproved license: 1 See RAT report in: /Users/hchen9/Workspace/incubator-eagle/eagle-core/eagle-policy/eagle-policy-base/target/rat.txt -> [Help 1]

Unapproved licenses:

incubator-eagle/eagle-core/eagle-policy/eagle-policy-base/src/main/resources/eagle.siddhiext

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants