Conversation
https://issues.apache.org/jira/browse/EAGLE-88 Clear the dependency to make dev able to start eagle-service with mvn tomcat7:run Add template monitor resource which returns OK for external monitoring
…nto aggergation
* @since Dec 21, 2015 | ||
* | ||
*/ | ||
public class DruidPersistService implements IPersistService<AggregateEntity> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you think to rename the DruidPersistService
to KafkaPersistService
here as it's for kafka only in fact? We may have another DruidPersistService
using https://github.com/druid-io/tranquility later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion, kafakpersistservice seems better.
Have you implemented the inline sql-based-policy interface? |
For sql-based-policy, i think it mean an policy executor accept a fixed sql. This would be added later, not in this commit. |
Ok, i think the pull request is good for me. |
The PR looks good to me |
Add aggregate purely on single user given QL support |
LGTM 👍 |
Will merge this pull request into master branch today if no additional comments. |
@RalphSu thanks for the contribution and pull request has been merged, please resolve the JIRA ticket https://issues.apache.org/jira/browse/EAGLE-79. |
Got RAT exception, but it doesn't matter, i will fix it.
Unapproved licenses:
|
https://issues.apache.org/jira/browse/EAGLE-79