New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Fxi sprk/egle issues in JPM module #943

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@asdf2014
Member

asdf2014 commented Jun 7, 2017

Fxi sprk issues in JPM module

@asdf2014 asdf2014 changed the title from [MINOR] Fxi sprk issues in JPM module to [MINOR] Fxi sprk/egle issues in JPM module Jun 7, 2017

@qingwen220

This comment has been minimized.

Contributor

qingwen220 commented Jun 7, 2017

@asdf2014 I do not think these are big issues.

On the other hand, this changes will have a big impact for users who have already installed these features. (old data are missing).

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Jun 7, 2017

@qingwen220 Yep, you are right. This will destroy backward compatibility. But, for people with obsessive compulsive disorder it still be a huge problem. Moreover, if you do not modify it now, then want to modify in future, it will become more difficult.

@jhsenjaliya

This comment has been minimized.

Contributor

jhsenjaliya commented Jun 8, 2017

@asdf2014 i know how it feels.
but as @qingwen220 pointed out, it will be too much work to make this compatible for people already running on branch 0.5
how about we take up this on next version 0.6 ? which is master after the master version changes.

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Jun 9, 2017

@jhsenjaliya Okay, i see :D

@asdf2014 asdf2014 closed this Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment