Skip to content
Permalink
Browse files
feat: add zr daily build
  • Loading branch information
Ovilia committed Apr 20, 2021
1 parent 4c31111 commit 6590f3015eacc1f8ffc85fd88618a26a0e9e6b62
Showing 2 changed files with 9 additions and 3 deletions.
@@ -125,10 +125,13 @@ module.exports = (app) => {
}

const content = context.payload.pull_request.body;
if (content && content.indexOf('[x] The API has been changed.') > -1) {
if (content && content.indexOf('[x] The API has been changed') > -1) {
labelList.push('PR: awaiting doc');
commentText += '\n\n' + text.PR_AWAITING_DOC;
}
if (content && content.indexOf('[x] This PR depends on ZRender changes') > -1) {
commentText += '\n\n' + text.PR_ZRENDER_CHANGED;
}

if (await isFirstTimeContributor(context)) {
labelList.push('PR: first-time contributor');
@@ -173,7 +176,7 @@ module.exports = (app) => {
}

const content = context.payload.pull_request.body;
if (content && content.indexOf('[x] The API has been changed.') > -1) {
if (content && content.indexOf('[x] The API has been changed') > -1) {
addLabels.push('PR: awaiting doc');
}
else {
@@ -53,7 +53,9 @@ const PR_OPENED_BY_COMMITTER = PR_OPENED + `
The pull request is marked to be \`PR: author is committer\` because you are a committer of this project.`;

const PR_AWAITING_DOC = `Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the \`PR: awaiting doc\` label.`;
const PR_AWAITING_DOC = `Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the \`PR: awaiting doc\` label.`;

const PR_ZRENDER_CHANGED = 'This PR depends on [ZRender](https://github.com/ecomfe/zrender) changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).\nYou can use `npm i zrender@npm:zrender-nightly@dev` to update package.json.\nIf you have any question about this, please leave a comment and we will give you extra help on this.';

const PR_MERGED =
`Congratulations! Your PR has been merged. Thanks for your contribution! 👍`;
@@ -90,6 +92,7 @@ module.exports = {
PR_OPENED_BY_COMMITTER,
PR_NOT_MERGED,
PR_AWAITING_DOC,
PR_ZRENDER_CHANGED,
ISSUE_TAGGED_WAITING_AUTHOR,
ISSUE_TAGGED_EASY,
ISSUE_TAGGED_PRIORITY_HIGH,

0 comments on commit 6590f30

Please sign in to comment.