Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkLine1DDataItemOption incorrectly defines xAxis as number #14300

Closed
Bilge opened this issue Feb 19, 2021 · 1 comment
Closed

MarkLine1DDataItemOption incorrectly defines xAxis as number #14300

Bilge opened this issue Feb 19, 2021 · 1 comment
Labels

Comments

@Bilge
Copy link
Contributor

Bilge commented Feb 19, 2021

Since strings are a valid time series data items, it is incorrect for markLine to require the xAxis data point to be a number.

Version

5.0.2

Steps to reproduce

const options: ECOption = {
    series: [{
        markLine: {
            data: [{
                xAxis: "foo",
            }]
        }
    }],
};

What is expected?

interface MarkLine1DDataItemOption {
  xAxis?: number|string;
}

What is actually happening?

interface MarkLine1DDataItemOption {
  xAxis?: number;
}
@echarts-bot
Copy link

echarts-bot bot commented Feb 19, 2021

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.

If you are interested in the project, you may also subscribe our mailing list.

Have a nice day! 🍵

@echarts-bot echarts-bot bot added bug en This issue is in English pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Feb 19, 2021
@Ovilia Ovilia removed pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Feb 22, 2021
Ovilia added a commit to apache/echarts-doc that referenced this issue Feb 22, 2021
Ovilia added a commit to apache/echarts-doc that referenced this issue Feb 22, 2021
pissang added a commit that referenced this issue Feb 23, 2021
fix(markLine): fix axis type in markLine data and close #14300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants