Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in src/util/types.ts #14716

Closed
shijieyao opened this issue Apr 20, 2021 · 9 comments
Closed

Typo in src/util/types.ts #14716

shijieyao opened this issue Apr 20, 2021 · 9 comments
Assignees
Labels
Milestone

Comments

@shijieyao
Copy link

Version

5.1.0

Steps to reproduce

It seems to a quick report of an easy-fix bug, so pardon me for not providing reproduction steps.

What is expected?

Successful compilation.

What is actually happening?

Error: node_modules/echarts/types/dist/echarts.d.ts:6391:14 - error TS1005: ']' expected.

6391 [key in ${ComponentMainType}Index]: number;
~
node_modules/echarts/types/dist/echarts.d.ts:6391:38 - error TS1005: ';' expected.

6391 [key in ${ComponentMainType}Index]: number;
~
node_modules/echarts/types/dist/echarts.d.ts:6391:39 - error TS1128: Declaration or statement expected.

6391 [key in ${ComponentMainType}Index]: number;
~
node_modules/echarts/types/dist/echarts.d.ts:6392:1 - error TS1128: Declaration or statement expected.

6392 } & {
~
node_modules/echarts/types/dist/echarts.d.ts:6392:3 - error TS1109: Expression expected.

6392 } & {
~
node_modules/echarts/types/dist/echarts.d.ts:6393:29 - error TS1005: ',' expected.

6393 [key in string]: unknown;
~m

@echarts-bot
Copy link

echarts-bot bot commented Apr 20, 2021

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.

If you are interested in the project, you may also subscribe our mailing list.

Have a nice day! 🍵

@echarts-bot echarts-bot bot added bug en This issue is in English pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Apr 20, 2021
@pissang pissang added this to the 5.1.1 milestone Apr 20, 2021
@echarts-bot
Copy link

echarts-bot bot commented Apr 20, 2021

This issue is labeled with priority: high, which means it's a frequently asked problem and we will fix it ASAP.

@pissang
Copy link
Contributor

pissang commented Apr 20, 2021

Hi @shijieyao. Thanks for the feedback. It's not a typo. It's because we are using the typescript template string feature which is introduced in typescript@4.1.0. It's not expected and will break the code using older typescript versions. We will fix it ASAP.

@shijieyao
Copy link
Author

I see. Thanks for the prompt reply!

@junchaohu
Copy link

Same issue here, wish for resolve

@Abattista96
Copy link

I have the same issue, also with the last update 5.1.1

@pissang
Copy link
Contributor

pissang commented Apr 29, 2021

@Abattista96 5.1.1 should have fixed it. Do you mind providing your reproducible code?

@junchaohu
Copy link

@pissang Already fixed in my project, thanks.

@Abattista96
Copy link

Abattista96 commented Apr 29, 2021

@Abattista96 5.1.1 should have fixed it. Do you mind providing your reproducible code?

I updated the lib version from 4.9 to 5.1.0, now to 5.1.1.
When i try to compile first time after the update i receive the error from some node_module not found, from the second compile the code give me the same error above and fail to compile in all cases. I really don't know what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants