Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enhance the behavior that when mouse move is out of echarts are. #11516

Merged
merged 1 commit into from Oct 31, 2019

Conversation

100pah
Copy link
Member

@100pah 100pah commented Oct 29, 2019

enhance: enhance the behavior that when mouse move is out of echarts area:
the brushed area or dataZoom window will be released at that case, but not keep in dragging state.
fix #10675.

But there is still an issue could be thought over:
When we are dragging and the pointer is moving out of the echarts area, should we release the dragging state, or keep the dragging state util mouseup/touchend?
For touchend they are almost the same. But for mouseup they are a little different.
If we need to make more detailed process for "mouse up out of echarts", we need to
listen mousemove and mouseup of document, which brings some extra effort in coding.

Please try them in dataZoom-action.html or bar.html.

…area: the brushed area or dataZoom window will be released at that case, but not keep in dragging state. fix #10675.
@pissang
Copy link
Contributor

pissang commented Oct 30, 2019

I think a better experience for dragging is keeping the state when the mouse is outside of chart. Currently it's really annoying when dragging on a dataZoom closing to the edge of chart.

If we bring this, #10675 will not be an issue.

@pissang
Copy link
Contributor

pissang commented Oct 31, 2019

Created an example about the current issue of dataZoom. https://jsfiddle.net/pissang/es4d87jx/59/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brush drag gets stuck when the mouse leaves the chart area
2 participants