Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): overflow symbols should render if clip is false #11549 #11552

Merged
merged 2 commits into from Nov 4, 2019
Merged

fix(line): overflow symbols should render if clip is false #11549 #11552

merged 2 commits into from Nov 4, 2019

Conversation

SnailSword
Copy link
Contributor

@SnailSword SnailSword commented Nov 3, 2019

fix #11549.

before:
image

after:
image

pissang
pissang approved these changes Nov 4, 2019
@@ -354,7 +354,7 @@ export default ChartView.extend({
// FIXME step not support polar
var step = !isCoordSysPolar && seriesModel.get('step');
var clipShapeForSymbol;
if (coordSys && coordSys.getArea) {
if (coordSys && coordSys.getArea && seriesModel.get('clip')) {
Copy link
Contributor

@pissang pissang Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more robust to use seriesModel.get('clip', true).

In this way it won't try get the clip property from the root option if it not exists in series.

@pissang pissang added this to the 4.6.0 milestone Nov 4, 2019
@pissang
Copy link
Contributor

pissang commented Nov 4, 2019

Thanks a lot! I've planned it in this version.

@SnailSword SnailSword requested a review from pissang Nov 4, 2019
pissang
pissang approved these changes Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbols don't render right in clip mode
3 participants