Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sankey frequent flashing with hovering on the node and edge #11306 #11572

Merged
merged 5 commits into from Nov 8, 2019

Conversation

deqingli
Copy link
Member

@deqingli deqingli commented Nov 6, 2019

  • Add an unfocusNodeAdjacency delay execution timer to delay execute the action.
  • Add focus state make sure to execute the right action.

@deqingli deqingli requested review from 100pah and pissang Nov 6, 2019
@pissang
Copy link
Contributor

pissang commented Nov 6, 2019

I think _unfocusDelayTimer needs to be cleared when graph / sankey status is changed.

Like in the render and focusNodeAdjacency.

@@ -163,17 +164,15 @@ export default echarts.extendChartView({

if (itemModel.get('focusNodeAdjacency')) {
el.on('mouseover', el[FOCUS_ADJACENCY] = function () {
clearTimeout(this._unfocusDelayTimer);
Copy link
Contributor

@pissang pissang Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to set this._unfocusDelayTimer to null here. And in the following code with clearTimeout

Copy link
Member Author

@deqingli deqingli Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have fixed it.

pissang
pissang approved these changes Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants