Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get font configs issue #11653

Merged
merged 1 commit into from Nov 18, 2019
Merged

fix get font configs issue #11653

merged 1 commit into from Nov 18, 2019

Conversation

code4fan
Copy link
Contributor

@code4fan code4fan commented Nov 15, 2019

The original logic will never get font configs from the textStyle option, and also the ecModel doesn't have other font configs except the textStyle option.

The original logical will never get font configs from the `textStyle` option, and also the `ecModel` doesn't have other font configs except the `textStyle` option.
`var gTextStyleModel = ecModel || ecModel.getModel('textStyle');`
Ovilia
Ovilia approved these changes Nov 15, 2019
Copy link
Contributor

@Ovilia Ovilia left a comment

Looks good for me.
I also met with this problem where the textContain.getWidth returned wrong result with custom font option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants