Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support toolbox.dataZoom brush component `dataZoom.slide… #11710

Merged
merged 3 commits into from Dec 2, 2019

Conversation

100pah
Copy link
Member

@100pah 100pah commented Nov 25, 2019

feature: support toolbox.dataZoom brush component dataZoom.slider visualMap.continuous drag outside and release outside.
That enhances the user experience of dragging.

zrender should be updated to the PR:
ecomfe/zrender#536

Check test/drag-out.html.

100pah added 2 commits Nov 25, 2019
y < 0 && (y = 0);
y > h && (y = h);

return [x, y];
Copy link
Contributor

@pissang pissang Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to clamp the mouse position to the canvas area.

pissang
pissang approved these changes Dec 2, 2019
@KrzysztofMadejski
Copy link

KrzysztofMadejski commented Jan 5, 2021

This apparently caused issue #12146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants