Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): fix bar width calculation with barMaxWidth constraint and barGap -100% #7356 #11713

Merged
merged 1 commit into from Nov 27, 2019

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Nov 26, 2019

Fix #7356

The cause of this bug is in the line https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L292

The width will be constraint by the remainedWidth, which is the space can still be used for the remaining series. It is calcuated in https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L321 In the original buggy code, the barGap is not considered. So the calculated remaining width is much smaller than it should be when the barGap is set -100%.

100pah
100pah approved these changes Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width on bar series is incorrect on some case with barGap set to '-100%' (overlap the bar)
2 participants