Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emphasis line style options do not work on Sankey charts #9942 #11729

Merged
merged 5 commits into from Dec 2, 2019

Conversation

deqingli
Copy link
Member

@deqingli deqingli commented Nov 27, 2019

Fix #9942.


el.downplay = function () {
this.trigger('normal');
};
Copy link
Member

@100pah 100pah Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should better not mount method dynamically to an instance.
It's fine just call el.trigger

100pah
100pah approved these changes Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emphasis line style options do not work on Sankey charts
3 participants