Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markLine): provide new layouts for markLine labels #11843

Merged
merged 3 commits into from Dec 19, 2019
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 12, 2019

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Provides new layouts for markLine labels.

Fixed issues

Details

Before: What was the problem?

image

The previous layout design may often cause the markLine labels to collapse.

After: How is it fixed in this PR?

image

Provide multiple new layout designs so that labels may not collapse.

image

Usage

Are there any API changes?

  • The API has been changed.

Valid values of has been changed from 'start', 'middle', 'end' to 'start', 'middle', 'end', 'insideStartTop', 'insideStartBottom', 'insideMiddleTop', 'insideMiddleBottom', 'insideEndTop', 'insideEndBottom'.

Related test cases or examples to use the new APIs

  • test/markLine.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

src/chart/helper/Line.js Outdated Show resolved Hide resolved
@Ovilia Ovilia merged commit 6aec55a into master Dec 19, 2019
@Ovilia Ovilia deleted the fix-11569 branch Dec 19, 2019
@Ovilia Ovilia added this to the 4.7.0 milestone Feb 21, 2020
Ovilia added a commit to apache/echarts-doc that referenced this pull request Feb 25, 2020
Ovilia added a commit to apache/echarts-examples that referenced this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants