Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing splitArea support for singleAxis #11690 #11890

Merged
merged 1 commit into from Jan 6, 2020

Conversation

newraina
Copy link
Contributor

@newraina newraina commented Dec 21, 2019

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

add singleAxis.splitArea support.

Fixed issues

#11690

Details

Before: What was the problem?

by doc, singleAxis should support splitArea option, actually not.

After: How is it fixed in this PR?

add _splitArea implement for SingleAxisView, imitate CartesianAxisView.

@pissang pissang modified the milestones: 4.8.0, 4.7.0 Dec 22, 2019
pissang
pissang approved these changes Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants