Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bar): bar background #11951

Merged
merged 11 commits into from Jan 13, 2020
Merged

feat(bar): bar background #11951

merged 11 commits into from Jan 13, 2020

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 30, 2019

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Provide background for bar series under both cartesian and polar coordinates.

Fixed issues

Details

Before: What was the problem?

No background.

After: How is it fixed in this PR?

Providing background options.

Usage

Are there any API changes?

  • The API has been changed.

Added series[bar].backgroundStyle option in the form of:

backgroundStyle: {
    color: 'transparent',
    borderColor: null,
    borderWidth: '0',
    borderType: 'solid',
    borderRadius: 0,
    shadowBlur: 0,
    shadowColor: '',
    shadowOffsetX: 0,
    shadowOffsetY: 0,
    opacity: 1
}

Related test cases or examples to use the new APIs

  • test/bar-large.html
  • test/bar-polar-basic-radial.html
  • test/bar-polar-basic.html
  • test/bar-polar-multi-series-radial.html
  • test/bar-polar-multi-series.html
  • test/bar.html
  • test/bar3.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@Ovilia Ovilia marked this pull request as ready for review Jan 6, 2020
src/chart/bar/BarSeries.js Show resolved Hide resolved
src/chart/bar/BarView.js Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Show resolved Hide resolved
src/chart/bar/BarSeries.js Outdated Show resolved Hide resolved
src/chart/bar/BarSeries.js Outdated Show resolved Hide resolved
src/chart/bar/BarSeries.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
src/chart/bar/BarView.js Outdated Show resolved Hide resolved
100pah
100pah approved these changes Jan 13, 2020
@Ovilia Ovilia merged commit 4023cfa into master Jan 13, 2020
@Ovilia Ovilia deleted the fix-11405 branch Jan 13, 2020
@Ovilia Ovilia added the PR: awaiting doc Document changes is required for this PR. label Feb 21, 2020
@Ovilia Ovilia added this to the 4.7.0 milestone Feb 21, 2020
@Ovilia Ovilia removed PR: awaiting review PR: awaiting doc Document changes is required for this PR. labels Feb 21, 2020
Ovilia added a commit to apache/echarts-doc that referenced this pull request Feb 25, 2020
Ovilia added a commit to apache/echarts-examples that referenced this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants