Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Markpoint): MarkPoint position with stack line/bar. Close #11535 #11965

Merged
merged 1 commit into from Jan 3, 2020

Conversation

yikuangli
Copy link

@yikuangli yikuangli commented Jan 2, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issue where in the charts contain stacked data, the markpoint's position is not correct.

Fixed issues

#11535
#11616

Details

Before: What was the problem?

The max,min,avg marker in the stacked bar or line graph with stacked data is misplaced.

image
image

After: How is it fixed in this PR?

Changed markerTypeCalculatorWithExtent function in the markerHelper, let it always use the stacked data(if they have stack) to calculate marker's coordinate, and get the value from the original data.

image
image

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

pissang
pissang approved these changes Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants