Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(themeRiver): use layer key map rather then largestLayer #11948 #12022

merged 3 commits into from
Aug 5, 2020


Copy link

@Zaynex Zaynex commented Jan 11, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Keep the number of layer keys in each layer consistent.

Fixed issues

Fixed issue #11948


Before: What was the problem?

Use largest layer array is not enough. Because each layer may have a different key, each layer array is inconsistent after call fixdata.


After: How is it fixed in this PR?

Save all the layer keys, and if any layer data lack one of keys, add default data(lack key: value) to layer .



Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

@pissang pissang added this to the 4.9.0 milestone Apr 15, 2020
@pissang pissang requested a review from 100pah August 4, 2020 15:37
@100pah 100pah merged commit ab3d9e4 into apache:master Aug 5, 2020
Copy link

echarts-bot bot commented Aug 5, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants