Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support tooltip.appendToBody. #12024

Merged
merged 1 commit into from Jan 13, 2020
Merged

Conversation

100pah
Copy link
Member

@100pah 100pah commented Jan 12, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

support tooltip.appendToBody.
Based on the PR ecomfe/zrender#559 .

Fixed issues

Fix #8049.

Details

The changes from #8049:

  • Add tooltip.appendToBody and by default false rather than "append to body" by default, otherwise bring a break change.
  • Support the existing features when appended to body for example show tooltip by dispatchAction, and do not trigger globalout when entering it.
  • Support positioning tooltip on document.body with CSS settings like margin, padding and even CSS transform.

Usage

Are there any API changes?

  • The API has been changed.
option = {
    tooltip: {
        appendToBody: true, // new option
        ...
    }
}

Related test cases or examples to use the new APIs

test/tooltip-appendToBody.html

@100pah 100pah merged commit c201b68 into master Jan 13, 2020
@100pah 100pah deleted the fix/tooltip-appendToBody branch Jan 13, 2020
@Ovilia Ovilia added the PR: awaiting doc Document changes is required for this PR. label Feb 21, 2020
@Ovilia Ovilia added this to the 4.7.0 milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants