Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable dispatchAction highlight downplay for treemap. fix #9816. #12050

Merged
merged 1 commit into from Jan 15, 2020

Conversation

100pah
Copy link
Member

@100pah 100pah commented Jan 14, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix: enable dispatchAction highlight downplay for treemap.

Fixed issues

fix #9816.

Details

Before: What was the problem?

Can not dispatchAction highlight downplay for treemap.

After: How is it fixed in this PR?

Enabled.

Related test cases or examples to use the new APIs

test/treemap-disk2.html

Others

Remain issue

Whether highlight/downplay will effect all the subtree or only the hovered node?
There are both scenarios, depending on the styles the treemap used. For example,
a treemap uses border to distinguish the highlighted subtree, we should only
highlight the target node rather than the entire subtree. Otherwise the all of the
border inner the subtree will be highlighted unexpectedly. If a treemap uses area
color to distinguish the highlighted subtree, the entire subtree needed to be
highlighted.

But I only support "highlight single node" here. Because based on the current
mechanism, implement "highlight entire subtree" need some more code, a little
like focusNodeAdjacency in graph series, and event more complicated because
the zrender elements in treemap are nested so we need to consider a mouse over
listener should/should not listen to its descendent.

@echarts-bot
Copy link

echarts-bot bot commented Jan 14, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@100pah 100pah merged commit a9ee949 into master Jan 15, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jan 15, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: treemap highlight action not triggered
3 participants