Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 11799 add new option 'nameProperty' in map series option #12156

Merged
merged 1 commit into from Feb 16, 2020

Conversation

alex2wong
Copy link
Contributor

@alex2wong alex2wong commented Feb 16, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

add new option 'nameProperty' in map series option to denote key in geoJSON data

Fixed issues

bug #11799

Details

Before: What was the problem?

In original version, geojson properties must have a property: "name". Now you can customize it.

After: How is it fixed in this PR?

add a new option in map series

Usage

Are there any API changes?

  • The API has been changed.
{
                            name: 'USA PopEstimates',
                            type: 'map',
                            map: 'USA',
                            nameProperty: 'NAME', // new option to denote key in geoJSON, default is 'name',
                            data: []
}

Related test cases or examples to use the new APIs

test/map-nameProperty.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 16, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Feb 16, 2020

LGTM

@pissang pissang added this to the 4.8.0 milestone Feb 16, 2020
@pissang pissang merged commit da128eb into apache:master Feb 16, 2020
@echarts-bot
Copy link

echarts-bot bot commented Feb 16, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added PR: awaiting doc Document changes is required for this PR. and removed PR: awaiting review labels Feb 27, 2020
alex2wong added a commit to apache/echarts-doc that referenced this pull request Mar 11, 2020
@alex2wong
Copy link
Contributor Author

alex2wong commented Mar 12, 2020

revise doc apache/echarts-doc#91, please take a look @pissang @Ovilia , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants