Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): label not show when animation is disabled. fix #12110 #12243

Merged
merged 3 commits into from Apr 10, 2020

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Mar 6, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Hover style is not used if pie animation is set to be false.

Fixed issues

Details

Before: What was the problem?

Test test/pie-animation.html. Label is not shown when hover on the pie.

After: How is it fixed in this PR?

labelLine.ignore = labelLine.hoverIgnore;
labelText.ignore = labelText.hoverIgnore;

labelLine.ignore and labelText.ignore should be changed into hoverIgnore, even if without animation.

Note that a user may set animation to be true while hoverAnimation to be false for a pie chart to have the transition animation at initiation. So checking both itemModel.get('hoverAnimation') && seriesModel.isAnimationEnabled() in 9847233#diff-19529e7aaddb5ad8b1b45417c96c8e00R184 does not update the animation states for transition animation.

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

test/pie-animation.html and a visual test about it.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 6, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 4.8.0 milestone Mar 16, 2020
src/chart/pie/PieView.js Show resolved Hide resolved
@Ovilia Ovilia merged commit 796d386 into master Apr 10, 2020
@echarts-bot
Copy link

echarts-bot bot commented Apr 10, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-12110 branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants