Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heatmap): 1px gap between rect #12342

Merged
merged 1 commit into from Mar 30, 2020
Merged

fix(heatmap): 1px gap between rect #12342

merged 1 commit into from Mar 30, 2020

Conversation

SnailSword
Copy link
Contributor

@SnailSword SnailSword commented Mar 27, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix #11975

Fixed issues

#11975

Details

Before: What was the problem?

#11975 There is a 1px gap between rects in some cases, e.g. 19 lines in total and dom height is 260px.
image

After: How is it fixed in this PR?

image

@echarts-bot
Copy link

echarts-bot bot commented Mar 27, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Mar 30, 2020

LGTM

@pissang pissang merged commit 22aef46 into apache:master Mar 30, 2020
@echarts-bot
Copy link

echarts-bot bot commented Mar 30, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heatmap: there is a tiny gap between each rect item,how to remove it?
2 participants