Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effectScatter): the ripple effect of effectScatter does not rotate as the rotation of scatter symbol when using functional symbolRotate. close #12353. #12354

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Mar 31, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the bug #12353.

Fixed issues

plainheart added 2 commits Mar 31, 2020
Merge some commits from apache/master
…e as the rotation of scatter symbol when using functional `symbolRotate`. close apache#12353.
@echarts-bot
Copy link

echarts-bot bot commented Mar 31, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 4.8.0 milestone Mar 31, 2020
@pissang pissang merged commit 50bab74 into apache:master Mar 31, 2020
@echarts-bot
Copy link

echarts-bot bot commented Mar 31, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/effect-scatter-ripple-not-rotate-as-expected branch Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants