Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: axis min/max function return null: #12371

Merged
merged 1 commit into from Apr 2, 2020
Merged

fix: axis min/max function return null: #12371

merged 1 commit into from Apr 2, 2020

Conversation

100pah
Copy link
Member

@100pah 100pah commented Apr 2, 2020

The original PR is: #12215
cf5812f
Fix from that:
(1) The min/max function call should not be called twice (necessary and probably wrong input params).
(2) fixMin fixMax should cover function return.
(3) Add more test cases.

The original PR is:  #12215
cf5812f
Fix from that:
(1) The min/max function call should not be called twice (necessary and probably wrong input params).
(2) `fixMin` `fixMax` should cover function return.
(3) Add more test cases.
@echarts-bot
Copy link

echarts-bot bot commented Apr 2, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

pissang
pissang approved these changes Apr 2, 2020
@100pah 100pah merged commit fb72a4c into master Apr 2, 2020
@echarts-bot
Copy link

echarts-bot bot commented Apr 2, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@100pah 100pah deleted the fix/axis-min-max-fn branch Apr 2, 2020
pissang added a commit that referenced this pull request Apr 26, 2020
pissang added a commit that referenced this pull request Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants