Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential security risk #12380

Merged
merged 3 commits into from Apr 7, 2020
Merged

Fix potential security risk #12380

merged 3 commits into from Apr 7, 2020

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Apr 4, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

open new link by 'blank' has security risk

Check this artical

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 4, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

pissang
pissang previously approved these changes Apr 4, 2020
@pissang
Copy link
Contributor

pissang commented Apr 4, 2020

Thanks @susiwen8 ! Can you put the logic of open in a helper function module in https://github.com/apache/incubator-echarts/tree/master/src/util ?

pissang
pissang approved these changes Apr 7, 2020
@pissang pissang added this to the 4.8.0 milestone Apr 7, 2020
@pissang pissang merged commit 7887f27 into apache:master Apr 7, 2020
@echarts-bot
Copy link

echarts-bot bot commented Apr 7, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the target branch Apr 7, 2020
plainheart added a commit that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants