Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataZoom): custom brush style in toolbox.feature.dataZoom #12550

Merged
merged 2 commits into from Aug 4, 2020
Merged

feat(dataZoom): custom brush style in toolbox.feature.dataZoom #12550

merged 2 commits into from Aug 4, 2020

Conversation

zhiyuc123
Copy link
Contributor

@zhiyuc123 zhiyuc123 commented May 1, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

allow user to custom brush style in toolbox.feature.dataZoom

Fixed issues

#8964

Details

Before: What was the problem?

框选型数据区域缩放组件不能更改选框颜色,在暗色主题下表现不好

After: How is it fixed in this PR?

允许用户通过配置自定义选框样式

   toolbox: {
        feature: {
            dataZoom: {
                show: true,
                yAxisIndex: null,
                brushStyle: {
                    borderWidth: 2,
                    color: 'blue',
                    opacity: 0.1,
                    borderColor: '#596A76',
                 }
            },
        }
    },

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 1, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 4.9.0 milestone May 3, 2020
@zhiyuc123 zhiyuc123 requested a review from pissang Aug 4, 2020
pissang
pissang approved these changes Aug 4, 2020
@pissang pissang merged commit 2e8961b into apache:master Aug 4, 2020
@echarts-bot
Copy link

echarts-bot bot commented Aug 4, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants