Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): added dispose method for rich tooltip, close #12607. #12608

Merged
merged 6 commits into from May 13, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented May 11, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Added the dispose method for rich tooltip, closes #12607.

Fixed issues

Details

Before: What was the problem?

An error will occur when calling chart.dispose().

After: How is it fixed in this PR?

Add the dispose method for TooltipRichContent.

Usage

Related test cases or examples to use the new APIs

Refer to test/tooltip-rich.html

plainheart added 6 commits Mar 31, 2020
Merge some commits from apache/master
Merge some commits from apache/master.
Merge some commits from apache/master.
Merge some commits from apache/master
Merge some commits from apache/master
@echarts-bot
Copy link

echarts-bot bot commented May 11, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link

@BardoQi BardoQi left a comment

Very good! We need it!

@pissang pissang merged commit 1b02954 into apache:master May 13, 2020
@echarts-bot
Copy link

echarts-bot bot commented May 13, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip renderMode richText doesn't have dispose
3 participants