Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveAsImage function, use document.defaultView instead of window #12643

Merged
merged 1 commit into from May 18, 2020

Conversation

lzr900515
Copy link
Contributor

@lzr900515 lzr900515 commented May 15, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • [ ] others

What does this PR do?

in some micro front-end framework( for examle taobao's qiankun framework), window maybe is a Proxy ,so use document.defaultView instead of it , to solve the saveAsImage error.

Fixed issues

before:
image

after:
image

@echarts-bot
Copy link

echarts-bot bot commented May 15, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 4.9.0 milestone May 18, 2020
@pissang pissang merged commit 4e5c6f7 into apache:master May 18, 2020
@echarts-bot
Copy link

echarts-bot bot commented May 18, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants