Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): richText for series-specific formatters #12232 #12664

Merged
merged 3 commits into from Aug 4, 2020
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented May 19, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix bugs with tooltip textStyle with:

A) In 'html' renderMode:

  • Enabling text shadow settings with all series

B) In 'richText' renderMode:

  • Enabling text shadow settings with all series
  • Enabling font settings with all series
  • Correcting new line for radar and map series and markers

Fixed issues

Details

Before: What was the problem?

image

After: How is it fixed in this PR?

image

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 19, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang
Copy link
Contributor

pissang commented Aug 4, 2020

Some of the change seems to be conflicts with #12947 Needs to merge carefully

pissang
pissang approved these changes Aug 4, 2020
@pissang pissang merged commit be6ad17 into master Aug 4, 2020
@echarts-bot
Copy link

echarts-bot bot commented Aug 4, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-12232 branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants