Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lines): lines series shouldn't disappear after setOption({}). (#12836) #12850

Merged
merged 1 commit into from Aug 4, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jun 23, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes the bug that lines series will disappear after setOption({}), closes #12836.

Fixed issues

Details

Before: What was the problem?

See #12836, #9212

After: How is it fixed in this PR?

Tweaked LinesSeries.mergeOption, removed the code line below

option.data = option.data || [];

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

Refer to test/lines-mergeOption.html.

@echarts-bot
Copy link

echarts-bot bot commented Jun 23, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

pissang
pissang approved these changes Aug 4, 2020
@pissang pissang merged commit 419336e into apache:master Aug 4, 2020
@echarts-bot
Copy link

echarts-bot bot commented Aug 4, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-lines-mergeOption-12836 branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants