Skip to content

[5.0] feat(animation): action from dataZoom and resize can override the animation in series.#12965

Merged
pissang merged 1 commit intonextfrom
datazoom-animation
Jul 14, 2020
Merged

[5.0] feat(animation): action from dataZoom and resize can override the animation in series.#12965
pissang merged 1 commit intonextfrom
datazoom-animation

Conversation

@pissang
Copy link
Contributor

@pissang pissang commented Jul 14, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Currently, we use the animationUpate options in series to transit the elements when data updated.

But in the case which user can trigger the update frequently, like dataZoom, resize. The long animation duration may let chart seems to be not responsive. Especially when we changed the default easing from 'cubicOut' to 'cubicInOut'.

So this pull request can let dataZoom and resize pass global animation config through payload. And when series do update, it will use the config in the payload instead of the animation config in the series. It will make the update faster, more responsive, and neater.

Result

DataZoom with Mouse Pan

Before

dataZoom-inside-before

After

dataZoom-inside-after

DataZoom with Slider

Before

dataZoom-slider-before

After

dataZoom-slider-after

Resize the Pie

Before

resize-before

After

resize-after

@echarts-bot
Copy link

echarts-bot bot commented Jul 14, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang merged commit 3769757 into next Jul 14, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jul 14, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the datazoom-animation branch July 18, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants