Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] [5.0] Improve style of dataZoom, visualMap, timeline components. Bug fixes from next branch #13008

Merged
merged 19 commits into from Jul 24, 2020

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jul 23, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This pull request improves the styling of dataZoom, visualMap, and timeline component.

In addition, this PR fixes a bunch of bugs in the next branch.

Details

dataZoom

Before

image

After

image

New Options

dataZoom: {
    /**
     * Border radius of the box.
     */
    borderRadius?: number | number[]
    /**
     * Style the thumb of the selected area.
     */
    selectedDataBackground?: {
        lineStyle?: LineStyleOption
        areaStyle?: AreaStyleOption
    }
}

visualMap

Before

image

After

image

New Options

visualMap: {
    // Icon string of handle
    handleIcon?: string,
    // Size of handle
    handleSize?: string | number,

    handleStyle?: ItemStyleOption

    indicatorIcon?: string,
    // Percent of the item width
    indicatorSize?: string | number,
    indicatorStyle?: ItemStyleOption

    emphasis?: {
        handleStyle?: ItemStyleOption
    }
}

timeline

Before

image

After

image

In GIF

timeline

New Options

timeline: {
    // Style in progress bar.
    progress?: {
        lineStyle?: TimelineLineStyleOption
        itemStyle?: ItemStyleOption
        label?: TimelineLabelOption
    }
}

Improve gaps between columns in the bar chart.

Related issue: #12935

Bug fixes

Fixes bugs which are from the testing of example page.

  • Fix hoverLayerThreshold not work in the next branch.
  • Fix image symbol not shown bug.
  • Fix echarts.format.getTextRect not exists error.
  • Fix unexpected black fill in lines series.
  • Support legacy color: 'auto' usage in the labels.
  • Fix axisPointer label wrong position bug.
  • Not blur other series when highlight is triggered by axisPointer

@echarts-bot
Copy link

echarts-bot bot commented Jul 23, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Ovilia
Ovilia approved these changes Jul 24, 2020
@pissang pissang merged commit b786334 into next Jul 24, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jul 24, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the optimize-style branch July 24, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants