Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make line bolder when line is in emphasis state, designed by #12931. #13013

merged 10 commits into from Jul 27, 2020


Copy link

@plainheart plainheart commented Jul 23, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

According to the suggested design change in #12931, add a new semantic value bolder for emphasis.lineStyle.width for line series to specify whether the line should be bolder when it's in emphasis state.

Fixed issues


Before: What was the problem?

The line series won't be bolder to highlight when hovering on it unless users specify emphasis.lineStyle.width.

After: How is it fixed in this PR?

By default, the line series will be bolder when hovering on it. But if users set emphasis.lineStyle.width as a specific number manually, it will be bolder as they specified.

2020-07-23 17 09 35


Are there any API changes?

  • The API has been changed.

Added a new semantic value bolder for emphasis.lineStyle.width , default value is bolder.

Related test cases or examples to use the new APIs

Refer to test/line-boldWhenHover.html


Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Jul 23, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/line/LineSeries.ts Outdated Show resolved Hide resolved
Copy link

pissang commented Jul 23, 2020

The screenshot seems nice! I commented suggestions about the option design. Others look good to me.

src/chart/line/LineView.ts Show resolved Hide resolved
@pissang pissang merged commit aff984a into apache:next Jul 27, 2020
Copy link

echarts-bot bot commented Jul 27, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the design-12931 branch December 30, 2020 08:10
plainheart added a commit that referenced this pull request Mar 11, 2021
- only make line bolder when there is more than one series and blur state
- or the user manually specify `lineStyle.width` as `bolder`
Copy link

Is there any way to disable the feature at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants