Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): showBackground bug when update with no previous background elements #13085

Merged
merged 1 commit into from Aug 6, 2020

Conversation

easonyq
Copy link

@easonyq easonyq commented Aug 6, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix 13009
Remove unnecessary var declaration, according to #13084

Fixed issues

Switch 'options -> series -> showBackground' from false to true will no longer throw exceptions. (something like calling useStyle from undefined, more detailed described in #13009 )

Details

Before: What was the problem?

Switch 'options -> series -> showBackground' from false to true will throw exceptions.

After: How is it fixed in this PR?

Switch 'options -> series -> showBackground' from false to true works well.

Usage

Are there any API changes?

  • The API has been changed.

No

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@easonyq easonyq changed the title Fix 13009 fix(bar): showBackground bug when update with no previous background elements Aug 6, 2020
@pissang pissang changed the base branch from master to release Aug 6, 2020
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Aug 6, 2020
@easonyq
Copy link
Author

easonyq commented Aug 6, 2020

Mainly same as #13084, but fix a small mistake about duplicate var declaration issue (line 195) which is raised by reviewers AFTER PR closed.

@plainheart
Copy link
Member

plainheart commented Aug 6, 2020

Thank you! You're flying to solve this.

pissang
pissang approved these changes Aug 6, 2020
@pissang pissang merged commit 59f9861 into apache:release Aug 6, 2020
@echarts-bot
Copy link

echarts-bot bot commented Aug 6, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@easonyq easonyq deleted the fix-13009 branch Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants