[5.0] [FEATURE] decal #13304
Merged
[5.0] [FEATURE] decal #13304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the |
echarts-bot
bot
added
PR: author is committer
PR: awaiting doc
|
TODO:
|
pissang
requested changes
Oct 15, 2020
Ovilia
commented
Oct 16, 2020
src/visual/aria.ts
Outdated
| if (userConfig == null) { | ||
| const pathArr = path.split('.'); | ||
| let result = ecModel.getLocale('aria'); | ||
| // FIXME: remove as any |
There was a problem hiding this comment.
@pissang Please help improve the type here.
Ovilia
commented
Oct 16, 2020
src/visual/aria.ts
Outdated
| function getSeriesTypeName(type) { | ||
| return ecModel.getLocale(['series', 'typeNames'])[type] || '自定义图'; | ||
| function getSeriesTypeName(type: string) { | ||
| // FIXME: remove as any |
There was a problem hiding this comment.
@pissang Please help improve the type here.
pissang
requested changes
Oct 20, 2020
pissang
reviewed
Oct 20, 2020
|
Some bugs from my test:
|
pissang
requested changes
Oct 21, 2020
pissang
requested changes
Oct 21, 2020
pissang
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Brief Information
This pull request is in the type of:
What does this PR do?
Support decal in ECharts, see #13263 for more details.
Fixed issues
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information