Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

german translation added #13315

Merged
merged 2 commits into from Sep 21, 2020
Merged

Conversation

YvesR
Copy link
Contributor

@YvesR YvesR commented Sep 21, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

Added german translation

@echarts-bot
Copy link

echarts-bot bot commented Sep 21, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@YvesR
Copy link
Contributor Author

YvesR commented Sep 21, 2020

@susiwen8 Added in new format. Please review.

I didn't dig into the changed i18n settings, just translated, so if you have to register DE as language in a config file, please advice.

@pissang
Copy link
Contributor

pissang commented Sep 21, 2020

Hi, @YvesR Thanks for the contribution.

The language source files are in the https://github.com/apache/incubator-echarts/tree/next/src/i18n

https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is an example template.

@YvesR
Copy link
Contributor Author

YvesR commented Sep 21, 2020

Hi, @YvesR Thanks for the contribution.

The language source files are in the https://github.com/apache/incubator-echarts/tree/next/src/i18n

https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is an example template.

Thanks for info, translation the wrong file. Ok, did add a new german ts file and commited.

@pissang
Copy link
Contributor

pissang commented Sep 21, 2020

Looks good, thanks!

@pissang pissang merged commit 76688aa into apache:next Sep 21, 2020
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Sep 21, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants