Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] [Feature] support largest-triangle-three-buckets based on 13317 #13337

merged 8 commits into from Sep 24, 2020


Copy link

@pissang pissang commented Sep 24, 2020

This pull request is forked from the PR #13317 by @SnailSword and did some modifications. Includes:

  • Fix params.start and params.end in the task is not the number after downsampled when using downsample without dataZoom. This leads to downsample not having any performance improvement.
  • Improve the performance of LTTB downsample, remove unnecessary temporary array creation in the original getPair internal method.
  • Fix bugs in some edge cases of LTTB downsample like NaN data handling.
  • Add performance and result comparison in the test case.
  • Fix wrong tooltip after downsampled

Here is a screenshot of the test case. All the code of cases has been JIT warmed up before run. To make sure the result is more consistent.


Copy link

echarts-bot bot commented Sep 24, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

100pah approved these changes Sep 24, 2020
@pissang pissang merged commit 06973ad into next Sep 24, 2020
Copy link

echarts-bot bot commented Sep 24, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants