Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Japanese i18n file #13470

merged 4 commits into from Oct 22, 2020

add: Japanese i18n file #13470

merged 4 commits into from Oct 22, 2020


Copy link

@swsoyee swsoyee commented Oct 21, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Support Japanese.

Fixed issues


Before: What was the problem?

After: How is it fixed in this PR?


Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

The terms were chosen with reference to the original Chinese and English translations file, and all Japanese terms have been subjected to detailed academic research, so there should be no problem.

Copy link

Thank you for providing the Japanese translation.
We are working on the release of the next version 5.0. Would you mind moving this commit to the next branch?

All the language source files are in is a template for your reference.

Thanks again.

@swsoyee swsoyee changed the base branch from master to next October 22, 2020 01:44
Copy link

plainheart commented Oct 22, 2020

Hi, there is some work to be done

Copy link
Contributor Author

swsoyee commented Oct 22, 2020

@plainheart Sorry for the delay, translation have been added, also switch the target branch and moved the file into src/i18n directory.

Copy link

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Please @pissang have a look. Then I think we can merge this pull request.

@plainheart plainheart added this to the 5.0.0 milestone Oct 22, 2020
@pissang pissang merged commit 47f95a8 into apache:next Oct 22, 2020
@swsoyee swsoyee deleted the i18n-japanese branch October 22, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants