Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(tooltip.borderColor): consider tooltipModel borderColor #13771

Merged
merged 1 commit into from Dec 14, 2020

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Dec 7, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

User borderColor has highest priority.

Fixed issues

Close #13770

Details

Before: What was the problem?

Screen Shot 2020-12-07 at 12 24 23

Screen Shot 2020-12-07 at 12 23 49

After: How is it fixed in this PR?

Screen Shot 2020-12-07 at 12 24 23

Screen Shot 2020-12-07 at 12 23 08

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 7, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 added this to the 5.0.1 milestone Dec 7, 2020
@susiwen8 susiwen8 modified the milestones: 5.0.1, 5.1.0 Dec 8, 2020
@pissang pissang modified the milestones: 5.1.0, 5.0.1 Dec 14, 2020
@pissang pissang merged commit 4fe2bd0 into apache:master Dec 14, 2020
@echarts-bot
Copy link

echarts-bot bot commented Dec 14, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

100pah added a commit that referenced this pull request Dec 15, 2020
100pah added a commit that referenced this pull request Dec 15, 2020
@susiwen8 susiwen8 deleted the toooltip-borderColor branch December 20, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting tooltip.borderColor is invalid
2 participants