Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/legend auto #13930

Merged
merged 3 commits into from Jan 3, 2021
Merged

Fix/legend auto #13930

merged 3 commits into from Jan 3, 2021

Conversation

100pah
Copy link
Member

@100pah 100pah commented Jan 3, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix:

  1. series data should not inherit its parents detected dimensions, because the detected dimensions might be based on different seriesLayoutBy.
  2. data-transform should fill back the detected dimensions to this result data, so that the downstream series can use the data in seriesLayoutBy: 'row'.
  3. fix Auto legend name and tooltip series name are not correct. #13915 (caused by 1)
  4. fix some ts type.

(1) series data should not inherit its parents detected dimensions, because the detected dimensions might be based on different `seriesLayoutBy`.
(2) data-transform should fill back the detected dimensions to this result data, so that the downstream series can use the data in `seriesLayoutBy: 'row'`.
(3) fix #13915 (caused by 1).
@echarts-bot
Copy link

echarts-bot bot commented Jan 3, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit bad5ffc into master Jan 3, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jan 3, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@100pah 100pah deleted the fix/legend-auto branch January 3, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto legend name and tooltip series name are not correct.
2 participants